Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance readme; add params to create_shinylive_url; other minor docs … #2

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Sep 19, 2024

  • enhance readme:
    • add usage in vignette
    • add gifs
  • add mode and header params to create_shinylive_url()
  • other minor docs updates

@pawelru pawelru requested a review from donyunardi September 19, 2024 10:40
@pawelru pawelru enabled auto-merge (squash) September 19, 2024 10:40
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Unit Tests Summary

 1 files   2 suites   0s ⏱️
13 tests 11 ✅ 2 💤 0 ❌
48 runs  46 ✅ 2 💤 0 ❌

Results for commit 717e91f.

♻️ This comment has been updated with latest results.

@pawelru pawelru marked this pull request as draft September 19, 2024 11:00
auto-merge was automatically disabled September 19, 2024 11:00

Pull request was converted to draft

@pawelru pawelru marked this pull request as ready for review September 19, 2024 11:01
@pawelru pawelru enabled auto-merge (squash) September 19, 2024 11:01
Copy link
Contributor

github-actions bot commented Sep 19, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/parse_url.R                   12       0  100.00%
R/tag_examplesShinylive.R       72       0  100.00%
TOTAL                           84       0  100.00%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  --------
R/parse_url.R       +3       0  +100.00%
TOTAL               +3       0  +100.00%

Results for commit: 717e91f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@pawelru
Copy link
Contributor Author

pawelru commented Sep 19, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new arguments to the create_shinylive_url works fine.
I only have minor comments, but I also think it might be a good idea to add unit tests for the new arguments.

R/parse_url.R Show resolved Hide resolved
R/parse_url.R Outdated Show resolved Hide resolved
@pawelru pawelru requested a review from donyunardi September 30, 2024 09:12
@donyunardi
Copy link

I have read the CLA Document and I hereby sign the CLA

@pawelru pawelru merged commit ee4cb78 into main Sep 30, 2024
29 of 30 checks passed
@pawelru pawelru deleted the enhancements branch September 30, 2024 22:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants